Update space_packet_parser version #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech3371
requested review from
bourque,
sdhoyt,
greglucas,
subagonsouth,
vmartinez-cu,
laspsandoval and
maxinelasp
and removed request for
a team
greglucas
reviewed
Apr 2, 2024
| "Tried to read .* bits when only 0 available." | ||
| ) | ||
| # TODO: Look into why it's giving different error message | ||
| expected_error_msg = "negative shift count" |
There was a problem hiding this comment.
This test doesn't make sense to me, can we just remove it?
Test that an error is raised if an empty file is passed to generate_xarray.
We are making sure space_packet_parser raises an error with bad data, but we can rely on them to test that.
There was a problem hiding this comment.
I am happy to remove it if Laura is ok.
bourque
approved these changes
Apr 2, 2024
tech3371
force-pushed
the
update_spp_version
branch
from
bcd2f9f to
3510ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Update space_packet_parser version and fixed one I-ALiRT test that was failing.