Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SWAPI science data CDF attribute #394

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Added SWAPI science data CDF attribute #394

merged 3 commits into from
Apr 11, 2024

Conversation

tech3371
Copy link
Contributor

@tech3371 tech3371 commented Apr 8, 2024

Change Summary

Overview

  • minor fix and couple TODOs after SWAPI reviewed my code.
  • added CDF attribute for SWAPI
  • change upper case to lower case in dataset

@tech3371
- minor fix and couple TODOs after SWAPI reviewed my code.
9001820 
- added CDF attribute for SWAPI
- change upper case to lower case in dataset
@tech3371 tech3371 added the Ins: SWAPI Related to the SWAPI instrument label Apr 8, 2024
@tech3371 tech3371 requested review from bryan-harter and a team April 8, 2024 22:02
@tech3371 tech3371 self-assigned this Apr 8, 2024
@tech3371 tech3371 requested review from bourque, sdhoyt, greglucas, subagonsouth, vmartinez-cu, laspsandoval and maxinelasp and removed request for a team April 8, 2024 22:02
bourque
bourque approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@bourque bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

imap_processing/swapi/swapi_cdf_attrs.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way this is organized, I am going to steal some ideas from this for CoDICE :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure!

@tech3371 tech3371 requested a review from bryan-harter April 11, 2024 17:53
@bryan-harter
Copy link
Contributor

Looks good!

@tech3371 tech3371 merged commit 1540b55 into IMAP-Science-Operations-Center:dev Apr 11, 2024
15 checks passed
@tech3371 tech3371 linked an issue Apr 23, 2024 that may be closed by this pull request
Write SWAPI L1A data to CDF file #188
Closed
@tech3371 tech3371 deleted the swapi_cdf branch July 25, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourque bourque bourque approved these changes

@sdhoyt sdhoyt Awaiting requested review from sdhoyt sdhoyt was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@greglucas greglucas Awaiting requested review from greglucas greglucas was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@subagonsouth subagonsouth Awaiting requested review from subagonsouth subagonsouth was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@vmartinez-cu vmartinez-cu Awaiting requested review from vmartinez-cu vmartinez-cu was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@laspsandoval laspsandoval Awaiting requested review from laspsandoval laspsandoval was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@maxinelasp maxinelasp Awaiting requested review from maxinelasp maxinelasp was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@bryan-harter bryan-harter Awaiting requested review from bryan-harter

Assignees

@tech3371 tech3371

Labels
Ins: SWAPI Related to the SWAPI instrument
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write SWAPI L1A data to CDF file
3 participants
@tech3371 @bryan-harter @bourque