Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding module path in imap_processing - fixes #47

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

tech3371
Copy link
Contributor

Change Summary

Adding imap_processing module path in the imap_processing init.py file and using it in decom code.

Overview

This issue came up when I was trying to install imap_processing in a dockerfile using pip and then calling decom code. Previously, I have hard coded the path and it become irrelevant when it was installed using pip.

Updated Files

  • imap_processing/init.py
    • Add way to get current path where imap-procesing pip module is located
  • imap_processing/swe/decom_swe.py
    • use above path to point to swe's decom packet definition

@tech3371 tech3371 requested a review from greglucas July 26, 2023 22:45
@tech3371 tech3371 self-assigned this Jul 26, 2023
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should think about what we want/need available in the root namespace later, and whether we should add a configuration dictionary with data paths, or add an __init__.py file to the packet_definitions directory so that path is directly discoverable in the installed package.

This can all be easily updated later, so this is a good approach to start with so we don't overcomplicate things right away.

@tech3371 tech3371 merged commit ccf1a8e into IMAP-Science-Operations-Center:dev Jul 26, 2023
laspsandoval pushed a commit to laspsandoval/imap_processing that referenced this pull request Nov 15, 2023
adding module path in imap_processing - fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants