MNT: Remove direct bitstring dependency #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do still bring it in via space packet parser, but we don't directly require it anymore.
greglucas
requested review from
a team,
bourque,
tech3371,
vmartinez-cu,
laspsandoval and
maxinelasp
and removed request for
a team
|
This is ready for review now as I think we are able to avoid its use for now still. |
bourque
approved these changes
Apr 26, 2024
greglucas
merged commit e8b7f9a
into
IMAP-Science-Operations-Center:dev
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
We do still bring it in via space packet parser, but we don't directly require it anymore.
Opening in draft for now in case @subagonsouth does still need this for Hi processing.New Dependencies
One less dependency
Updated Files