CoDICE L1a Lo Sunward Angular Counts #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourque
added
Ins: CoDICE
tech3371
approved these changes
May 3, 2024
| @@ -82,6 +82,15 @@ | |||
| instrument_base=codice_base, | |||
| ) | |||
|
|
|||
| l1a_lo_sw_angular_counts_attrs = GlobalDataLevelAttrs( | |||
| data_type="L1A_SCI->Level-1A Science Data", | |||
There was a problem hiding this comment.
Suggested change
| data_type="L1A_SCI->Level-1A Science Data", | |
| data_type="L1A_Lo-SW-Angular-Counts->Level-1A Lo Sunward Angular Counts Data", |
There was a problem hiding this comment.
If I remember correctly, this data_type is used to build filename convention that SPDF and SKTEditor use. That’s why I made suggestion to match the format it expects, <datalevel>_<descriptor>. Logical_source is used by write_cdf function to build our filename we use to write to.
There was a problem hiding this comment.
Good to know, thanks! I am going to add this to my list of things to fix in the next PR, since I should update it for the other data products too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This PR implements
lo-sw-angular-countsinto the CoDICE L1a pipeline. There are some fixes that need to be made to the pipeline based on conversations with Joey, but I will take care of those in a future PR.New Files
imap_processing/tests/codice/data/lo_fsw_view_7_ccsds.binlo-sw-angular-countsUpdated Files
imap_processing/codice/cdf_attrs.pyimap_processing/codice/codice_l0.pyimap_processing/codice/codice_l1a.pylo-sw-angular-countsimap_processing/codice/constants.pyimap_processing/codice/packet_definitions/P_COD_LO_SW_ANGULAR_COUNTS.xmlimap_processing/tests/codice/test_codice_l1a.py