Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up some L1A hist CDF issues found when reviewing output file #547

Merged
merged 2 commits into from
May 7, 2024
Merged

Cleaning up some L1A hist CDF issues found when reviewing output file #547

merged 2 commits into from
May 7, 2024

Conversation

subagonsouth
Copy link
Contributor

Change Summary

  • Change histogram counter var_type to data
  • Use common cdf attributes definition for ESA_STEP
  • Extend text in catdesc for histogram counter variables

Overview

This just cleans up a few loose ends that I noticed when reviewing the Hi L1a Histogram CDF files.

Updated Files

  • imap_processing.hi.hi_cdf_attrs.py
    • Change histogram counter var_type to data
    • Remove hist specific esa_step attributes definition
  • imap_processing.hi.l1a.histogram.py
    • Use common cdf attributes definition for ESA_STEP
    • Extend text in catdesc for histogram counter variables

@subagonsouth subagonsouth requested review from a team, bourque, sdhoyt, greglucas, tech3371, vmartinez-cu, laspsandoval and maxinelasp and removed request for a team May 6, 2024 16:24
greglucas
greglucas approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very minor nitpick that you can ignore if you prefer the current formatting.

imap_processing/hi/l1a/histogram.py Outdated Show resolved Hide resolved
@subagonsouth subagonsouth merged commit 440ed18 into IMAP-Science-Operations-Center:dev May 7, 2024
15 checks passed
@subagonsouth subagonsouth deleted the 545-clean-up-l1a-hist-cdf-file branch July 23, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglucas greglucas greglucas approved these changes

@bourque bourque bourque approved these changes

@sdhoyt sdhoyt Awaiting requested review from sdhoyt sdhoyt was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@tech3371 tech3371 Awaiting requested review from tech3371 tech3371 was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@vmartinez-cu vmartinez-cu Awaiting requested review from vmartinez-cu vmartinez-cu was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@laspsandoval laspsandoval Awaiting requested review from laspsandoval laspsandoval was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

@maxinelasp maxinelasp Awaiting requested review from maxinelasp maxinelasp was automatically assigned from IMAP-Science-Operations-Center/imap-sdc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subagonsouth @bourque @greglucas