Inital Codice L1b processing (for SIT-3) #622
Conversation
bourque
added
Ins: CoDICE
bourque
requested review from
sdhoyt,
greglucas,
subagonsouth,
tech3371,
vmartinez-cu,
laspsandoval and
maxinelasp
and removed request for
a team
| l1b_dataset.attrs["cdf_filename"] = write_cdf(l1b_dataset) | ||
| logger.info(f"\tCreated CDF file: {l1b_dataset.cdf_filename}") | ||
|
|
||
| return l1b_dataset |
There was a problem hiding this comment.
Could return just the filename instead of the whole dataset?
There was a problem hiding this comment.
Yeah, I think I could do that for L1b. For L1a, I am returning the whole dataset to make it easier to write unit tests (in that way, my test code doesn't need to go open the file), but since my L1b tests are just checking the filename, I could just return that instead.
There was a problem hiding this comment.
Gotcha, yeah, whatever works better for you
imap_processing/codice/codice_l1b.py
Outdated
|
|
||
| # Write the dataset to CDF | ||
| logger.info(f"\nFinal data product:\n{l1b_dataset}\n") | ||
| l1b_dataset.attrs["Data_version"] = data_version |
There was a problem hiding this comment.
Does adding the version directly replace needing to make this call? attr_mgr.add_global_attribute("Data_version", data_version)
There was a problem hiding this comment.
Good catch. i just forgot to update this to use that method of setting the Data_version.
Change Summary
Overview
This PR adds initial support for CoDICE L1b data products. It is pretty bare bones for now, just to get data products produced for the SIT-3 test (for example, the data arrays are simply being converted from integers to floats). This will be revisited after SIT-3 to actually apply appropriate processing.
New Files
imap_processing/cdf/config/imap_codice_global_cdf_attrs.yamlimap_processing/codice/codice_l1b.pyimap_processing/tests/codice/test_codice_l1b.pyUpdated Files
imap_processing/cdf/config/imap_codice_global_cdf_attrs.yamlimap_processing/cli.py