Glows fixes for deployment #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxinelasp
requested review from
bourque,
sdhoyt,
greglucas,
subagonsouth,
tech3371,
vmartinez-cu and
laspsandoval
and removed request for
a team
greglucas
approved these changes
Jun 14, 2024
tech3371
approved these changes
Jun 17, 2024
| @@ -261,6 +261,7 @@ def download_dependencies(self): | |||
| # TODO: determine what dependency information is optional | |||
| # TODO: Add in timestamps and descriptor to query | |||
| return_query = imap_data_access.query( | |||
| start_date=self.start_date, | |||
There was a problem hiding this comment.
Thank you for catching this
maxinelasp
merged commit 4171239
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This includes a few minor fixes to have the GLOWS code fully run in AWS. Mostly dealing with some weird variable and attribute collisions. This also updates the CLI to retrieve the date as part of the dependency retrieval.
Updated Files