Add Hi sensor name to imap_hi_l1b_hk products #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert l1b hk to use CDF attribute manager Move Logical_source update to common l1b location Update test value for l1b_hk Logical_source
subagonsouth
added
Ins: Hi
subagonsouth
requested review from
bourque,
sdhoyt,
greglucas,
tech3371,
vmartinez-cu,
daralynnrhode and
anamanica
and removed request for
a team
tech3371
reviewed
Jun 17, 2024
| # TODO: write a function that extracts the sensor from Logical_source | ||
| # some functionality can be found in imap_data_access.file_validation but | ||
| # only works on full file names | ||
| sensor_str = logical_source_parts[-1].split("-")[0] |
There was a problem hiding this comment.
Before you had like this, was that not working?
sensor_str = l1a_dataset.attrs["Logical_source"].split("_")[-1].split("-")[0]
There was a problem hiding this comment.
That was working, but it was parsing directly from Logical_source. I moved this code up into the hi_l1b function where I had already performed the first part of the parsing. Line 39 of hi_l1b.py:
logical_source_parts = l1a_dataset.attrs["Logical_source"].split("_").
Ultimately, this logic should be moved to a common location so that any instrument that wants to parse the sensor from Logical_source or filename can call that function.
There was a problem hiding this comment.
Ah ok. Sorry, missed that part. Cool, that makes sense.
tech3371
approved these changes
Jun 17, 2024
subagonsouth
merged commit 9b1c351
into
IMAP-Science-Operations-Center:dev
17 checks passed
subagonsouth
deleted the
632-add-hi-sensor-name-to-imap_hi_l1b_hk-products
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes missing sensor name in Hi l1b housekeeping file
Overview
New Dependencies
None
New Files
None
Deleted Files
None
Updated Files
Testing
Test updated with new Logical_source value
closes #632