Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cdf attribute tests #637
Cdf attribute tests #637
Changes from 1 commit
24cc329
f7d0262
484d838
56389b2
af3f48f
64a3672
d336f90
6258bca
34c7a98
fbceece
5348fb7
8dc2b82
1d56ef9
9e14421
b1c5209
2423921
4e1990f
79f3ba9
a6426c0
6936749
33bd956
4c3c4f2
4f6e3fb
9e43ad8
3d797d1
0bb6b88
d2fe904
4045f94
84b78a9
c454d3c
be0d064
f446db3
67271cc
0bff645
e1644bf
1029e2d
db68128
53cbb04
da12644
4a7712a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should pass the source_dir_input into the super() init function because there are steps in
__init__
that depend on the source_dir and it would be confusing to have it set to different values for the init vs for the rest of processing.Then you can remove line 21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has actually been causing me a lot of weird struggles with testing this class. In CdfAttributeManager , the default schema and IMAPS default variables are in the "config" file path and not guaranteed in the source_dir_input file path. I can't get the tests to run correctly without loading in that default info first, and then switching the file path... Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In those tests, you can pass in the "config" path (or pass in nothing and use the default) and then override it. This way it will still get the default schemas and global variables from "config" but you can also access your test files in the other file path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hahaha, happy to say I just got it. Thank you so much! I see now.