Move MAG L1A to CDF attribute manager #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class Sensor(Enum): | ||
| """Enum for MAG sensors: raw, MAGo, and MAGi (RAW, MAGO, MAGI).""" | ||
|
|
||
| MAGO = "MAGO" |
There was a problem hiding this comment.
Suggested change
| MAGO = "MAGO" | |
| MAGO = "MAGO" # MAGo sensor for outer measurements |
maxinelasp
requested review from
a team,
bourque,
sdhoyt,
subagonsouth and
tech3371
and removed request for
a team
|
Hi Maxine! I obviously shouldn't be the one to approve this, but I think this looks awesome. Your code for the CdfAttributes class is really awesome, it makes the code look super clean (just like Laura said). |
greglucas
approved these changes
Jul 19, 2024
@anamanica I don't see an issue with you approving this. If you agree with it, feel free to put your stamp of approval on it :) |
tech3371
reviewed
Jul 19, 2024
Closed
maxinelasp
merged commit 50302ec
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Since the MAG code has 4 files with similar attributes but different data, this is kind of a weird change. I rearranged some pieces to try and reduce the overall complexity.
The attribute manager mostly made it simpler.
Overview
Deleted Files
Sorry, I know this PR is a little complex, but I couldn't really find a good way of splitting it up as I was halfway through a refactor when we switched CDF management systems...