Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switched SWAPI CDF attrs to use YAML #704

Merged
merged 1 commit into from
Jul 24, 2024
Merged

switched SWAPI CDF attrs to use YAML #704

merged 1 commit into from
Jul 24, 2024

Conversation

tech3371
Copy link
Contributor

Change Summary

Overview

Moved SWAPI to use YAML config

New Files

  • imap_processing/cdf/config/imap_swapi_global_cdf_attrs.yaml
  • imap_processing/cdf/config/imap_swapi_variable_attrs.yaml

Deleted Files

  • imap_processing/swapi/swapi_cdf_attrs.py

Updated Files

  • imap_processing/swapi/l1/swapi_l1.py
    • uses new yaml config

Testing

imap_processing/tests/swapi/test_swapi_l1.py

@tech3371 tech3371 added Ins: SWAPI Related to the SWAPI instrument Level: L1 Level 1 processing CDF Related to CDF files labels Jul 23, 2024
@tech3371 tech3371 requested review from greglucas and maxinelasp July 23, 2024 16:14
@tech3371 tech3371 self-assigned this Jul 23, 2024
@tech3371 tech3371 linked an issue Jul 23, 2024 that may be closed by this pull request
Transition SWAPI to use CDF YAML config #705
Closed
maxinelasp
maxinelasp approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice

imap_processing/cdf/config/imap_swapi_variable_attrs.yaml Show resolved Hide resolved
@tech3371 tech3371 merged commit c1027aa into IMAP-Science-Operations-Center:dev Jul 24, 2024
17 checks passed
@tech3371 tech3371 deleted the swapi_yml branch July 25, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxinelasp maxinelasp maxinelasp approved these changes

@greglucas greglucas Awaiting requested review from greglucas

Assignees

@tech3371 tech3371

Labels
CDF Related to CDF files Ins: SWAPI Related to the SWAPI instrument Level: L1 Level 1 processing
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transition SWAPI to use CDF YAML config
2 participants
@tech3371 @maxinelasp