Mypy Update #731
Merged
Mypy Update #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daralynnrhode
requested review from
maxinelasp,
bourque,
greglucas,
laspsandoval and
tech3371
greglucas
reviewed
Aug 8, 2024
bourque
approved these changes
Aug 8, 2024
greglucas
approved these changes
Aug 8, 2024
maxinelasp
approved these changes
Aug 8, 2024
| @@ -109,7 +109,9 @@ def __post_init__(self) -> None: | |||
| # Convert string output from space_packet_parser to numpy array of | |||
| # big-endian bytes | |||
| self.VECTORS = np.frombuffer( | |||
| int(self.VECTORS, 2).to_bytes(len(self.VECTORS) // 8, "big"), | |||
| int(self.VECTORS, 2).to_bytes(len(self.VECTORS) // 8, "big"), # type: ignore[arg-type] | |||
| # TODO Check MYPY Error: Argument 1 to "int" has incompatible type | |||
There was a problem hiding this comment.
I can check on this, I'm updating things related to this code soon
daralynnrhode
merged commit e6908f8
into
IMAP-Science-Operations-Center:dev
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Kinda long, so sorry for that. Feel free to only check the files that concern your instrument.
Ensuring that both pre-commit mypy and a local mypy check will return the same outputs. In doing so, more errors were found and will be fixed within this PR.
numpy is weird:
As a way to avoid redeclaring a type, ie.
indices: np.ndarray = np.where(valid)[0]that should be inferred to be anp.ndarraybecause of what thenp.where()returns, but is not. Instead function returns ofnp.ndarraywere changed tonpt.NDArrayfrom the numpy typing library. I believe in most instance it will represent the same thing.This did however cause the build the docs to fail to recognize the type for some functions, but not all. Just added an ignore to the
config.pyfile.*
np.arrayis not an object type, it is a function that returns annp.ndarray.object: np.array =is not valid.Closes #710
New Dependencies
New Files
Updated Files
pyproject.toml
pre-commit-config.yaml
docs/source/conf.py
Testing