-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data access api README/Docs update #744
base: dev
Are you sure you want to change the base?
Data access api README/Docs update #744
Conversation
…processing into data-access-api Updating branch
Merge branch 'dev' of github.com:IMAP-Science-Operations-Center/imap_processing into data-access-api
Merge branch 'dev' of github.com:IMAP-Science-Operations-Center/imap_processing into data-access-api
Adding @greglucas as a reviewer here since he wrote most of this documentation and may have opinions about this! |
I would personally prefer the opposite direction 🤷 I think a package should be standalone if possible and the README should describe whats going on within that package without needing to click somewhere else. I just don't know how feasible any of it is to go either direction. |
Merge branch 'dev' of github.com:IMAP-Science-Operations-Center/imap_processing into data-access-api-README
Merge branch 'dev' of github.com:IMAP-Science-Operations-Center/imap_processing into data-access-api-README
Merge branch 'dev' of github.com:IMAP-Science-Operations-Center/imap_processing into data-access-api-README
Command Line Utility | ||
==================== | ||
To Install | ||
---------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command Line Utility | |
==================== | |
To Install | |
---------- | |
Command Line Utility | |
-------------------- | |
To Install | |
^^^^^^^^^^ |
It looks like these headings (and throughout this document) are still messing up the main RtD page layout. I think these need to be changed to another level 'down' in markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! Sorry, Okay. I think I understand what you are saying now! Should I do this with every heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, except for the very first one (line 4), which is fine as is.
.. openapi:: openapi.yml | ||
:group: | ||
:include: /query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is describing the REST API specification, so it should be moved to under that section.
.. openapi:: openapi.yml | ||
:group: | ||
:include: /download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the last comment, this is describing the REST API so should also be moved (same with the /upload
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates, this is looking really good! As Greg suggested, I think it is worth exploring if we can automatically include the contents of the imap-data-access
README
file in here, but that can be explored in a separate PR if you'd like.
I just have a few suggestions to help clarify some areas or make them a bit more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this document is quite lengthy now and have several sections and subsections, I suggest to add a table of contents somewhere towards the top. (Could be done in a future PR if desired)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, Ana pointed out to me that there is a built-in table of contents on ReadTheDocs, which I totally missed!
Merge branch 'dev' of github.com:IMAP-Science-Operations-Center/imap_processing into data-access-api-README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those updates, this looks good to go!
@anamanica Just a heads up that you will likely run into merge conflicts once #844 is merged, since that PR is changing the directory names a bit. |
@anamanica are you planning on merging this soon? |
Change Summary
Overview
This PR combines the information in the README for the data access api into the docs.
(I will have to cut down the README in a PR on the
imap-data-access
repo.)New Dependencies
None
New Files
None
Deleted Files
None
Updated Files
Testing
None