Lo L1A Histogram packet_to_dataset() Refactor and CDF Creation

[sdhoyt]

Change Summary

Overview

This PR refactors the the Lo L1A histogram code to use the packet_to_dataset() function and adds code to create the L1A CDF. There ended up being more changes that I had hoped, so I can try to break this up if needed. What I was doing on this branch evolved a bit over time, so this isn't a compartmentalized as a should be.

New Dependencies

None

New Files

• lo_science.py
  • new L1A science processing file. Currently only contains histogram processing

Deleted Files

• science_counts.py
  • science counts data class not needed with packets_to_dataset()
• lo_data_container.py
  • data container for data classes no longer needed with packets_to_dataset()
• lo_l1a_write_cdfs.py
  • Planning to set CDF attributes in lo_l1a.py main processing file. No longer need this file.

Updated Files

• imap_lo_l1a_variable_attrs.yaml
  • renamed tof histogram attributes so they don't conflict with DE tof attributes
• cli.py
  • removed list around processing function return
• lo_apid.py
  • removed needed APIDs
• lo_base.py
  • updated space packet parser import. This file will eventually be removed once everything is converted to use packets_to_dataset.
• lo_l1a.py
  • Refactored to use packets_to_dataset, removed temporary code from SIT-3, and added cdf attribute creation for L1A hist
• lo_xtce.xml
  • fixed name of sci count field.

Testing

• Updated test_lo_l1a.py and test_science_counts.py.
• Tested with cli.py

[greglucas]

Leaving some initial feedback for now, likely won't be able to review again for a while, so don't wait for my final review/approval.

[subagonsouth]

Looks good to me. I left one nit pick on naming. Ping me for review again once you address some of gregs comments.

[laspsandoval]

A few comments/suggestions.

[subagonsouth]

@sdhoyt, it is not clear to me what comments have been addressed or that you feel are resolved. Can you mark what you think is done as resolved and then ping me and I will review.

[sdhoyt]

@sdhoyt, it is not clear to me what comments have been addressed or that you feel are resolved. Can you mark what you think is done as resolved and then ping me and I will review.

@subagonsouth All the comments are now marked as resolved. Most of the CDF YAML related comments are resolved by the creation of this issue: #843. I'm going to make improvements to the YAML in a separate PR.

[subagonsouth]

Sorry for the slow feedback.