-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIT-2 Release [main] #83
Conversation
This adds the basics to start building our docs and organizing the sphinx page structure.
…kdown formatting throughout
Merge main to dev
…tead of 80, added instructions for installing pre-commit hooks
updates: - [github.com/psf/black: 22.12.0 → 23.3.0](psf/black@22.12.0...23.3.0) - [github.com/charliermarsh/ruff-pre-commit: v0.0.245 → v0.0.275](astral-sh/ruff-pre-commit@v0.0.245...v0.0.275) - [github.com/python-poetry/poetry: 1.4.0 → 1.5.0](python-poetry/poetry@1.4.0...1.5.0)
Adding documentation builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we already have released the code.
https://pypi.org/project/imap-processing/#history
Did you release that off of main, or the 0.1.0 branch? I don't see any tags, so I'm confused what that release corresponds to and how this workflow will go into that. Maybe that was just a temporary release on push? But, then I think we will get a complaint about a release already existing, so maybe you need to yank that one before triggering this actual workflow release?
# Get the name of the build sdist file for later use | ||
echo "SDIST_NAME=$(ls -1 dist)" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Get the name of the build sdist file for later use | |
echo "SDIST_NAME=$(ls -1 dist)" >> $GITHUB_OUTPUT |
outputs: | ||
SDIST_NAME: ${{ steps.sdist.outputs.SDIST_NAME }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outputs: | |
SDIST_NAME: ${{ steps.sdist.outputs.SDIST_NAME }} |
I don't think we use that here. It is only used in those other examples when combining sdists and wheels, but it looks like you are just doing sdist and avoiding needing this.
Thinking more about this. Do we need the
We could keep these branches around then and backport whatever we needed to them. This would also eliminate confusion over what version main is and where we are releasing from and remove this need for a massive PR. Thoughts? |
@greglucas Yes, that release was from me testing out the Actions workflow (it worked!). I think you are right -- I will have to remove this release on PyPI before we make the GitHub release. |
I think you could try to use the test pypi: https://packaging.python.org/en/latest/guides/using-testpypi/ but you also might need to add credentials there and authenticate too so might be more work than it is worth... Yanking might also not work because the artifacts are still there: https://snarky.ca/what-to-do-when-you-botch-a-release-on-pypi/ |
For reviewers: Please review the
release.yml
file, as that is a new file being introduced in this PR. Also please review the release notes and let me know if anything should be added/removed/changed. Everything else has already been reviewed in past PRs.Change Summary
Overview
This PR marks the release of version
0.1.0
(which is the first release ofimap_processing
), which corresponds to the completion of SIT-2. This PR is being merged back intomain
per the nominal git & GitHub workflow and release workflow.These are the release notes that will go into the GitHub release:
New Dependencies
pydata-sphinx-theme
sphinx
myst-parser
New Files
The only new file to actually review is
.github/workflows/release.yml
, which is a workflow for uploading the release to PyPI.Testing
The new
release.yml
workflow was tested by triggering the workflow uponpush
. The workflow successfully completed (see here: https://github.com/IMAP-Science-Operations-Center/imap_processing/actions/runs/6341963633).The
0.1.0
version of the package was uploaded to PyPI: https://pypi.org/project/imap-processing/To test this, one can
pip install imap-processing
in a new environment and make sure0.1.0
gets successfully installed.