-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made tools directory and updated .toml #84
Made tools directory and updated .toml #84
Conversation
The precommit is going to fail because you didn't update the poetry.lock file- once you've fixed that and everything is green, this looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pre-commit checks are going to be failing until the linting is fixed even though you updated the lock file. I'd suggest prioritizing those changes since they are not really architectural per-se, but should be a matter of going through and fixing line lengths, text casing, etc.
Additionally, I think if you move these into an optional block you'll need to re-run the command to generate the poetry.lock file. I'd suggest installing the pre-commit hooks locally with pre-commit install
as well, which automatically handles all of that for me before allowing me to make a commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
pyproject.toml
Outdated
|
||
[tool.poetry.extras] | ||
dev = ["black", "pre-commit", "ruff"] | ||
doc = ["myst-parser", "pydata-sphinx-theme", "sphinx"] | ||
test = ["pytest", "pytest-cov"] | ||
test = ["pytest"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a duplicate test
. Can you remove this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Change Summary
Completed these two action items from ISSUE #75. Organized already committed files into 'tools' directory.
Updated Files