Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made tools directory and updated .toml #84

Merged
merged 9 commits into from
Aug 31, 2023
Merged

Made tools directory and updated .toml #84

merged 9 commits into from
Aug 31, 2023

Conversation

GFMoraga
Copy link
Contributor

Change Summary

Completed these two action items from ISSUE #75. Organized already committed files into 'tools' directory.

- We need to add pandas, openpyxl to poetry dependency list
- Made a new directory called 'tools' under the 'imap_processing', as well as 'tools/xtce_generation' which will house the files to make xtce

Updated Files

  • pyproject.toml
    • pandas = ">=2.0.0,<3" & openpyxl = ">=3.0.7,<4"

@GFMoraga GFMoraga added Repo: Documentation Improvements or additions to documentation Level: L0 Level 0 processing labels Aug 28, 2023
@GFMoraga GFMoraga self-assigned this Aug 28, 2023
@maxinelasp
Copy link
Contributor

The precommit is going to fail because you didn't update the poetry.lock file- once you've fixed that and everything is green, this looks good to me!

Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit checks are going to be failing until the linting is fixed even though you updated the lock file. I'd suggest prioritizing those changes since they are not really architectural per-se, but should be a matter of going through and fixing line lengths, text casing, etc.

Additionally, I think if you move these into an optional block you'll need to re-run the command to generate the poetry.lock file. I'd suggest installing the pre-commit hooks locally with pre-commit install as well, which automatically handles all of that for me before allowing me to make a commit.

pyproject.toml Outdated Show resolved Hide resolved
@GFMoraga GFMoraga marked this pull request as draft August 29, 2023 17:07
Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@GFMoraga GFMoraga marked this pull request as ready for review August 30, 2023 16:31
@GFMoraga GFMoraga requested review from greglucas and tech3371 August 30, 2023 16:31
@GFMoraga GFMoraga marked this pull request as draft August 30, 2023 20:27
pyproject.toml Outdated

[tool.poetry.extras]
dev = ["black", "pre-commit", "ruff"]
doc = ["myst-parser", "pydata-sphinx-theme", "sphinx"]
test = ["pytest", "pytest-cov"]
test = ["pytest"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a duplicate test. Can you remove this one?

@GFMoraga GFMoraga marked this pull request as ready for review August 31, 2023 15:10
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@greglucas greglucas merged commit d940ee6 into IMAP-Science-Operations-Center:dev Aug 31, 2023
@GFMoraga GFMoraga deleted the xtce-decom-2 branch August 31, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: L0 Level 0 processing Repo: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants