fixed linting issues #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourque
previously requested changes
Aug 29, 2023
There was a problem hiding this comment.
Nice work @GFMoraga, these changes look good to me, especially if they are following ruff/black conventions.
I have some suggestions on how to improve the formatting (and location) of docstrings to bring them up to standards. I am going to request that they be changed because I think this is a good time to do that. We can also talk more about this during our meeting this afternoon.
maxinelasp
reviewed
Aug 29, 2023
bourque
requested changes
Aug 29, 2023
|
@all-contributors please add @GFMoraga for maintenance! |
|
I've put up a pull request to add @GFMoraga! 🎉 |
|
Thank you @bourque for the thorough review! |
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Nov 15, 2023
…nting fixed linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixed linting issues that caused a stick-in-the-mud
Overview
Ran 'ruff' and 'black on all files that where causing merge issues
Ran pre-commit run --all-files to make sure it would pass all tests
Updated Files