Convert all hi instances of uint64 CDF variables to int64 #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subagonsouth
requested review from
bourque,
sdhoyt and
tech3371
and removed request for
a team
greglucas
approved these changes
Sep 24, 2024
tech3371
approved these changes
Sep 24, 2024
Comment on lines
37
to
39
| FORMAT: I20 | ||
| VALIDMIN: 0 | ||
| VALIDMAX: 18446744073709551615 |
There was a problem hiding this comment.
Are these still good with change from uint64 to int64?
There was a problem hiding this comment.
Ah... Good catch! Nope, those are not correct.
subagonsouth
merged commit d728aec
into
IMAP-Science-Operations-Center:dev
17 checks passed
subagonsouth
deleted the
871-hi-product-definition-update-convert-uint64-to-int64
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This is a simple change converting all Hi CDF variables that were defined as uint64 to int64 since uint64 does not exist in CDF.
Updated Files
Closes #871