795 spice instrument pointing at specified time #903
Conversation
…ame_transform funciton Parameterize frame_transform test Add frame_transform coverage for multiple ets and single position vector
Add test coverage for instrument_pointing funciton
subagonsouth
requested review from
greglucas,
tech3371,
vmartinez-cu and
laspsandoval
imap_processing/spice/geometry.py
Outdated
| return pointing | ||
| if isinstance(et, typing.Collection): | ||
| return np.array([spice.reclat(vec)[1:] for vec in pointing]) | ||
| return np.array(spice.reclat(pointing)[1:]) |
There was a problem hiding this comment.
spice.reclat() returns radians. These should probably be converted to degrees.
| @@ -62,6 +62,24 @@ class SpiceFrame(IntEnum): | |||
| IMAP_GLOWS = -43750 | |||
|
|
|||
|
|
|||
| # TODO: Update boresight for in-situ instruments | |||
| # TODO: Confirm ENA boresight vectors | |||
| BORESIGHT_LOOKUP = { | |||
There was a problem hiding this comment.
This is my low effort initial approach to defining instrument boresights. I am open to suggestions of how to make this better, where to move this definition, etc. I still don't know if we should eventually create an instrument kernel that defines these. I need to get a better understanding of all of the requirements from all of the instruments before making that decision.
There was a problem hiding this comment.
Do we have to use .name or can it just be the enumeration itself as the lookup?
imap_processing/spice/geometry.py
Outdated
| return np.array([spice.reclat(vec)[1:] for vec in pointing]) | ||
| return np.array(spice.reclat(pointing)[1:]) |
There was a problem hiding this comment.
| return np.array([spice.reclat(vec)[1:] for vec in pointing]) | |
| return np.array(spice.reclat(pointing)[1:]) | |
| return np.rad2deg([spice.reclat(vec)[1:] for vec in pointing]) | |
| return np.rad2deg(spice.reclat(pointing)[1:]) |
| @@ -62,6 +62,24 @@ class SpiceFrame(IntEnum): | |||
| IMAP_GLOWS = -43750 | |||
|
|
|||
|
|
|||
| # TODO: Update boresight for in-situ instruments | |||
| # TODO: Confirm ENA boresight vectors | |||
| BORESIGHT_LOOKUP = { | |||
There was a problem hiding this comment.
Do we have to use .name or can it just be the enumeration itself as the lookup?
Convert radians to degrees for lat/lon output
subagonsouth
merged commit 63b77e8
into
IMAP-Science-Operations-Center:dev
subagonsouth
deleted the
795-spice-instrument-pointing-at-specified-time
branch
Change Summary
Overview
Add preliminary function for computing instrument pointing using spice.
Updated Files
instrument_pointingfunctionCloses: #795