Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ultra l1b Annotated #989

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Update Ultra l1b Annotated #989

merged 3 commits into from
Oct 28, 2024

Conversation

laspsandoval
Copy link
Contributor

Change Summary

Overview

  • Now uses SPICE tool frame_transform
  • Calculates the particle velocity in the DPS frame wrt to the heliosphere

Updated Files

  • ultra_l1b_annotated.py
    • Now uses SPICE tool frame_transform
    • Calculates the particle velocity in the DPS frame wrt to the heliosphere

Testing

  • test_ultra_l1b_annotated.py
    • Tests ultra_l1b_annotated.py

@laspsandoval laspsandoval self-assigned this Oct 7, 2024
@laspsandoval laspsandoval added SPICE Related to SPICE Ins: Ultra Related to the IMAP-Ultra instrument labels Oct 7, 2024
@laspsandoval laspsandoval added this to the Oct 2024 milestone Oct 7, 2024
@laspsandoval laspsandoval linked an issue Oct 7, 2024 that may be closed by this pull request
Ultra l1b Annotated Completion #990
Closed
subagonsouth
subagonsouth reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress. I have a couple of items to be addressed. Let me know if you want to discuss the use of external spice kernels. It is quite confusing.

@laspsandoval laspsandoval deleted the pset_exposure_helio branch October 28, 2024 18:36
@laspsandoval laspsandoval restored the pset_exposure_helio branch October 28, 2024 18:47
@laspsandoval laspsandoval reopened this Oct 28, 2024
@laspsandoval laspsandoval merged commit c67d3ee into IMAP-Science-Operations-Center:dev Oct 28, 2024
32 checks passed
@laspsandoval laspsandoval deleted the pset_exposure_helio branch October 28, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subagonsouth subagonsouth subagonsouth approved these changes

@sdhoyt sdhoyt Awaiting requested review from sdhoyt

Assignees

@laspsandoval laspsandoval

Labels
Ins: Ultra Related to the IMAP-Ultra instrument SPICE Related to SPICE
Projects
IMAP
Status: Done
Milestone
Oct 2024
Development

Successfully merging this pull request may close these issues.

Ultra l1b Annotated Completion
2 participants
@laspsandoval @subagonsouth