TST: Update s3 bucket tests for latest cdk updates

The cdk added PutBucketPolicy to their list of actions when creating the cloudformation.
IMAP-Science-Operations-Center · Nov 10, 2023 · 24b4814 · 24b4814
1 parent 9fc788a
commit 24b4814
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 5 deletions.
diff --git a/tests/infrastructure/test_backup_bucket_stack.py b/tests/infrastructure/test_backup_bucket_stack.py
@@ -29,7 +29,6 @@ def test_s3_config_bucket_resource_properties(template):
             "UpdateReplacePolicy": "Delete",
         },
     )
-
     template.has_resource_properties(
         "AWS::S3::Bucket",
         {
@@ -58,7 +57,12 @@ def test_s3_data_bucket_policy_resource_properties(template):
                 "Version": "2012-10-17",
                 "Statement": [
                     {
-                        "Action": ["s3:GetBucket*", "s3:List*", "s3:DeleteObject*"],
+                        "Action": [
+                            "s3:PutBucketPolicy",
+                            "s3:GetBucket*",
+                            "s3:List*",
+                            "s3:DeleteObject*",
+                        ],
                         "Effect": "Allow",
                         "Principal": {
                             "AWS": {

diff --git a/tests/infrastructure/test_data_manager_stack.py b/tests/infrastructure/test_data_manager_stack.py
@@ -123,7 +123,12 @@ def test_s3_data_bucket_policy_resource_properties(template):
                 "Version": "2012-10-17",
                 "Statement": [
                     {
-                        "Action": ["s3:GetBucket*", "s3:List*", "s3:DeleteObject*"],
+                        "Action": [
+                            "s3:PutBucketPolicy",
+                            "s3:GetBucket*",
+                            "s3:List*",
+                            "s3:DeleteObject*",
+                        ],
                         "Effect": "Allow",
                         "Principal": {
                             "AWS": {
@@ -172,7 +177,12 @@ def test_s3_config_bucket_policy_resource_properties(template):
             "PolicyDocument": {
                 "Statement": [
                     {
-                        "Action": ["s3:GetBucket*", "s3:List*", "s3:DeleteObject*"],
+                        "Action": [
+                            "s3:PutBucketPolicy",
+                            "s3:GetBucket*",
+                            "s3:List*",
+                            "s3:DeleteObject*",
+                        ],
                         "Effect": "Allow",
                         "Principal": {
                             "AWS": {
@@ -224,7 +234,12 @@ def test_s3_snapshot_bucket_policy_resource_properties(template):
             "PolicyDocument": {
                 "Statement": [
                     {
-                        "Action": ["s3:GetBucket*", "s3:List*", "s3:DeleteObject*"],
+                        "Action": [
+                            "s3:PutBucketPolicy",
+                            "s3:GetBucket*",
+                            "s3:List*",
+                            "s3:DeleteObject*",
+                        ],
                         "Effect": "Allow",
                         "Principal": {
                             "AWS": {