Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup bucket tests #146

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Backup bucket tests #146

merged 2 commits into from
Aug 23, 2023

Conversation

maxinelasp
Copy link
Contributor

@maxinelasp maxinelasp commented Aug 23, 2023 •
edited
Loading

Change Summary

Adding tests for the backup bucket changes (#125)

Overview

Adding tests for backup bucket CDK to finish off that ticket

New Dependencies

None

New Files

  • test_backup_bucket_stack.py
    • tests for backup bucket stack

Deleted Files

  • None

Updated Files

  • test_data_manager_stack.py

    • added two new tests for roles

  • sds_data_manager.py

Testing

@maxinelasp maxinelasp self-assigned this Aug 23, 2023
tech3371
tech3371 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

greglucas
greglucas approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for coming back and adding these!

@maxinelasp maxinelasp merged commit c028282 into IMAP-Science-Operations-Center:dev Aug 23, 2023
@maxinelasp maxinelasp deleted the backup-bucket-tests branch August 23, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglucas greglucas greglucas approved these changes

@tech3371 tech3371 tech3371 approved these changes

@sdhoyt sdhoyt Awaiting requested review from sdhoyt

@bourque bourque Awaiting requested review from bourque

@bryan-harter bryan-harter Awaiting requested review from bryan-harter

@laspsandoval laspsandoval Awaiting requested review from laspsandoval

@GFMoraga GFMoraga Awaiting requested review from GFMoraga

Assignees

@maxinelasp maxinelasp

Labels
None yet
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxinelasp @greglucas @tech3371