Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api dockerfile for testing #219

Merged

Conversation

laspsandoval
Copy link
Contributor

@laspsandoval laspsandoval commented Jan 16, 2024

Change Summary

Overview

Command line program that downloads a file from the s3_uri, modifies it, and uploads the modified file to the same s3 uri.

New Files

  • imap_api.py
    • Command line program that downloads a file from the s3_uri, modifies it, and uploads the modified file to the same s3 uri.
  • Dockerfile.testing
    • Creates image that will be used for testing batch_starter.py.

Testing

Since the script is only used for testing I did not perform tests on imap_api.py apart from checking that a new file with expected naming appeared in the s3 bucket (from the s3_uri).

Example:
docker build -f Dockerfile.testing -t test-image . --no-cache
docker run test-image s3://sds-data-449431850278/imap/hit/l0/2024/01/imap_hit_l0_sci_20240101_20240104_v02-01.pkts

@laspsandoval laspsandoval self-assigned this Jan 16, 2024
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just minor suggestions that don't change any of the content.

tests/docker_images/Dockerfile.testing Outdated Show resolved Hide resolved
tests/docker_images/imap_api.py Outdated Show resolved Hide resolved
tests/docker_images/imap_api.py Outdated Show resolved Hide resolved
tests/docker_images/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@laspsandoval laspsandoval merged commit 86b2cac into IMAP-Science-Operations-Center:dev Jan 17, 2024
2 checks passed
@laspsandoval laspsandoval deleted the api_dockerfile branch April 23, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants