Add event rule to batch starter lambda #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
approved these changes
Jan 26, 2024
Comment on lines
17
to
18
| logger.setLevel(logging.INFO) | ||
| logging.basicConfig(stream=sys.stdout, level=logging.DEBUG) |
There was a problem hiding this comment.
Why are these set separately? I think we can get rid of the basicConfig and sys import and put this logger to debug.
Suggested change
| logger.setLevel(logging.INFO) | |
| logging.basicConfig(stream=sys.stdout, level=logging.DEBUG) | |
| logger.setLevel(logging.DEBUG) |
There was a problem hiding this comment.
That's how we had in indexer and it's been able to log. I recall batch job logging troublesome. I am testing it on AWS.
There was a problem hiding this comment.
Ok. That seems to work. It just produced long logs that I haven't seen before. I see INFO logs I usually see.
…ixed tests with new changes. fixed logging.
tech3371
force-pushed
the
add_event_to_batch_starter
branch
from
10b9493 to
7a641da
Compare
tech3371
merged commit 6432f1b
into
IMAP-Science-Operations-Center:dev
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary