-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I-ALiRT: Add query api to s3 bucket #398
Merged
laspsandoval
merged 16 commits into
IMAP-Science-Operations-Center:dev
from
laspsandoval:api_s3_bucket
Dec 3, 2024
Merged
I-ALiRT: Add query api to s3 bucket #398
laspsandoval
merged 16 commits into
IMAP-Science-Operations-Center:dev
from
laspsandoval:api_s3_bucket
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laspsandoval
requested review from
bryan-harter,
bmcclellan-cu,
torimarbois and
maxinelasp
November 13, 2024 19:04
laspsandoval
force-pushed
the
api_s3_bucket
branch
from
November 13, 2024 19:27
d814dc0
to
bc26640
Compare
maxinelasp
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about adding some additional docs, but once that's done it looks good to me!
torimarbois
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit and one formatting question. Besides those, LGTM!
laspsandoval
force-pushed
the
api_s3_bucket
branch
from
December 3, 2024 15:45
2fa4839
to
5320cbe
Compare
laspsandoval
merged commit Dec 3, 2024
c46c59c
into
IMAP-Science-Operations-Center:dev
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
OpsSW will need to query (and eventually download) their log files. What is the most important to them is that they are able to see the most recent log file. I have based the query on their feedback.
New Files
Updated Files
Testing
Also I used the following GET command in Postman after deploying the stack:
https://vbnjpnz7ic.execute-api.us-west-2.amazonaws.com/prod/ialirt-log-query?year=2024&doy=045&instance=1
The output was
{
"files": [
"flight_iois_1.log.2024-045T16-54-46_123456.txt"
]
}
as expected