moved pull request template one directory up #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdhoyt
requested review from
bourque,
greglucas,
tech3371,
bryan-harter,
laspsandoval,
GFMoraga and
maxinelasp
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## development #78 +/- ##
============================================
Coverage 86.49% 86.49%
============================================
Files 21 21
Lines 955 955
============================================
Hits 826 826
Misses 129 129 ☔ View full report in Codecov by Sentry. |
greglucas
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
I agree this looks like it will work.
xref: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository
bourque
approved these changes
Jun 22, 2023
laspsandoval
approved these changes
Jun 22, 2023
tech3371
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
The pull request template was moved one directory up and is now located in the .github directory. It appears that when the pull request template is placed in a PULL_REQUEST_TEMPLATE folder like I had before, you need to use a PR URL with a query string that selects the template you want. Placing the template directory in the .github directory should automatically select it when a PR is created. The template file was also renamed with underscores rather than dashes to match the correct naming syntax to be automatically selected.
Sorry for this extra PR.