MAINT Fix broken sphinx-book-theme reference in CI #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Oct 17, 2023
requirements-dev.txt
Outdated
| @@ -6,7 +6,7 @@ plotly | |||
| jupyter-book>=0.11 | |||
| # Partial fix for the navbar scrollToActive behavior: | |||
| # https://github.com/executablebooks/sphinx-book-theme/issues/541 | |||
| sphinx-book-theme @ git+https://github.com/ogrisel/sphinx-book-theme@fix-bd-docs-nav | |||
| sphinx-book-theme @ git+https://github.com/executablebooks/sphinx-book-theme/commit/aca0f7fd39314ec3283f1ff798b4bf8ee9b49cad | |||
There was a problem hiding this comment.
ArturoAmorQ
commented
Oct 17, 2023
ogrisel
reviewed
Oct 17, 2023
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
ogrisel
approved these changes
Oct 17, 2023
|
I think we still have a broken CI: Later PRs are rising: error: subprocess-exited-with-error
× Building wheel for sphinx-book-theme (pyproject.toml) did not run successfully.
│ exit code: 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI was running on the branch related the PR executablebooks/sphinx-book-theme#754. When the branch was erased by the merge, the CI got broken.
This PR fixes the issue by pointing to the respective commit.