Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: set bd-docs-nav as a class attribute instead of an id to restore compat with pydata-sphinx-theme JS #754

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Aug 30, 2023

This is a partial fix for #541.

It makes the scrollToActive function from pydata-sphinx-theme.js work as expected on jupyter-book rendered HTML.

However, this function does not save the collapsed state of other sections which make the "scroll to saved location" a bit weird/broken at times.

Still, it's already much better than the current state.

@welcome
Copy link

welcome bot commented Aug 30, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes - this looks good, thanks for noticing and making the PR!

@choldgraf choldgraf merged commit aca0f7f into executablebooks:master Oct 10, 2023
@welcome
Copy link

welcome bot commented Oct 10, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@ogrisel ogrisel deleted the fix-bd-docs-nav branch October 16, 2023 08:22
@agoose77 agoose77 changed the title FIX set bd-docs-nav as a class attribute instead of an id to restore compat with pydata-sphinx-theme JS FIX: set bd-docs-nav as a class attribute instead of an id to restore compat with pydata-sphinx-theme JS Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants