Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless test case #882

Closed
wants to merge 2 commits into from
Closed

Remove useless test case #882

wants to merge 2 commits into from

Conversation

duribreux
Copy link

This test doesn't test anything - @GerardPaligot

@GerardPaligot
Copy link
Contributor

This test come from this commit. It isn't useless but just not finished.

A better contribution could be to add the missing asserts: clone the local variable and add these asserts:

+ assertEquals(localVarRef.getDeclaration(), declaration);
+ assertTrue(localVarRef.getDeclaration() == declaration);
+ assertEquals(localVarRefCloned.getDeclaration(), declarationCloned);
+ assertTrue(localVarRefCloned.getDeclaration() == declarationCloned);

@duribreux
Copy link
Author

duribreux commented Oct 10, 2016

I improved the test based on your comment and I've "probably" found a bug.
It seems that the parent of localVarRef is null and getDeclaration() needs it.

I don't have time to dig into Spoon to understand what's happening :/

@GerardPaligot
Copy link
Contributor

Someone made shit recently. :-°

@monperrus
Copy link
Collaborator

monperrus commented Oct 10, 2016

Someone made shit recently. :-°

It's not appropriate to say this.

It's called a regression on an untested case.

@monperrus
Copy link
Collaborator

closed by #888

Thanks @duribreux , it starts with a System.out, it ends with a bug.

@monperrus monperrus closed this Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants