Fix getReference and getDeclaration for local type #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msteinbeck
reviewed
Oct 10, 2016
| @@ -74,7 +74,8 @@ public void accept(CtVisitor visitor) { | |||
| // validating that the parent of a finding is parent of this | |||
| // reference as well | |||
| for (final CtLocalVariable<T> lv : localVariables) { | |||
| if (hasParent(lv.getParent())) { | |||
| // Since the getReference() is setting the LocalVariable as parent | |||
There was a problem hiding this comment.
I don't understand this comment.
monperrus
reviewed
Oct 10, 2016
| final CtLocalVariableReference localVarRefCloned = localVarCloned.getReference(); | ||
|
|
||
| assertEquals(localVarRef.getDeclaration(), localVar); | ||
| assertTrue(localVarRef.getDeclaration() == localVar); |
danglotb
force-pushed
the
fix-getRefDecl
branch
from
6a4a751
to
3346342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the test case.