Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files/user-config): make configs admin-configurable #63

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

bromiesTM
Copy link

@bromiesTM bromiesTM commented Dec 2, 2024

@bromiesTM bromiesTM force-pushed the kh/dev/make-file-configs-configurable branch from d656013 to 6d6cf77 Compare December 2, 2024 15:29
@printminion-co printminion-co self-requested a review December 3, 2024 08:29
Copy link

@printminion-co printminion-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's

please check #64

apps/files/lib/Service/UserConfig.php Outdated Show resolved Hide resolved
@bromiesTM bromiesTM force-pushed the kh/dev/make-file-configs-configurable branch 4 times, most recently from 42f7dda to df7b844 Compare December 9, 2024 15:23
@printminion-co printminion-co self-requested a review December 10, 2024 13:19
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@printminion-co printminion-co force-pushed the kh/dev/make-file-configs-configurable branch from df7b844 to 4572cda Compare December 10, 2024 13:19
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
@bromiesTM bromiesTM force-pushed the kh/dev/make-file-configs-configurable branch from 4572cda to 5d930c3 Compare December 11, 2024 08:29
@printminion-co printminion-co merged commit f11dd61 into ionos-dev Dec 11, 2024
4 of 5 checks passed
@printminion-co printminion-co deleted the kh/dev/make-file-configs-configurable branch December 11, 2024 08:54
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants