Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mk/review/kh/dev/make file configs configurable #64

Conversation

printminion-co
Copy link

@printminion-co printminion-co commented Dec 3, 2024

  • added test of UserConfig service
  • found and fixed bug in nextcloud

one can run tests via phpunit --configuration tests/phpunit-autotest-files.xml

phpunit-autotest-files.xml

<?xml version="1.0" encoding="utf-8" ?>
<!--
 - SPDX-FileCopyrightText: 2014-2016 ownCloud, Inc.
 - SPDX-License-Identifier: AGPL-3.0-only
-->
<phpunit bootstrap="bootstrap.php"
		 verbose="true"
		 timeoutForSmallTests="900"
		 timeoutForMediumTests="900"
		 timeoutForLargeTests="900"
>
	<testsuite name='app files'>
		<directory suffix=".php">../apps/files/tests</directory>
		<!-- exclude backends as they are called separately -->
		<exclude>../apps/files/tests/Storage/</exclude>
	</testsuite>
	<!-- filters for code coverage -->
	<filter>
		<!-- whitelist processUncoveredFilesFromWhitelist="true" -->
		<whitelist>
			<file>../lib/private/Files/Storage/DAV.php</file>
			<directory suffix=".php">../apps/files</directory>
			<exclude>
				<directory suffix=".php">../apps/files/l10n</directory>
				<directory suffix=".php">../apps/files/3rdparty</directory>
				<directory suffix=".php">../apps/files/tests</directory>
			</exclude>
		</whitelist>
	</filter>
	<!--<listeners>
		<listener class="StartSessionListener" file="startsessionlistener.php" />
	  <listener class="TestCleanupListener" file="testcleanuplistener.php">
		<arguments>
			<string>detail</string>
		</arguments>
	  </listener>
	</listeners>-->
</phpunit>

validate coverage for the app

composer require --dev phpunit/php-code-coverage
export XDEBUG_MODE=coverage
phpunit --configuration tests/phpunit-autotest-files.xml --coverage-html ./files_coverage

_home_cr_develop_easycloud_nc-server_files_coverage_apps_files_lib_Service_UserConfig php html

printminion-co and others added 4 commits December 3, 2024 15:51
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co and others added 4 commits December 5, 2024 10:01
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Not ok: in_array("foo", [true, false]); // returns true
ok: in_array("foo", [true, false], true); // returns false

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
Signed-off-by: Kai Henseler <kai.henseler@strato.de>
@bromiesTM bromiesTM force-pushed the kh/dev/make-file-configs-configurable branch from 0e8d566 to 04f1f2a Compare December 5, 2024 09:03
@bromiesTM bromiesTM force-pushed the kh/dev/make-file-configs-configurable branch 2 times, most recently from 42f7dda to df7b844 Compare December 9, 2024 15:23
@printminion-co printminion-co force-pushed the kh/dev/make-file-configs-configurable branch from df7b844 to 4572cda Compare December 10, 2024 13:19
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants