Project Part 4 Feedback

Jump to bottom Edit New page

Haiming247 edited this page Dec 12, 2013 · 2 revisions

Code Base: Good 2/3

Consistent coding style
All necessary requirements implemented
Lacks in-app help

Tangible Demo: Excellent 3/3

For the demo: good interaction with audience, good structure
Maybe need to add some exception handling when ES fails?
Presentation missing 1 person

Code Documentation: Excellent 3/3

Consistent and easy to interpret

Test Cases: Good 2/3

All tests passed; Test covers all controllers and models
Try to think of a way to test your new treeView package

OOD: Good 1/2

The class diagram seems fine. For the sequence diagram, it seems you want to show the scenario of reading a story, but the sequence diagram only shows the part till you open a story fragment, missing more important parts.

Release Planning: Excellent 1/1

Interesting and realistic

Addressing Feedback: Excellent 1/1

Addressed feedback adequately

Refactoring: Excellent 2/2

Did some code refactoring manually but the reason not to use JDeodorant tool sounds fine

Requirements: Good 2/3

Documented 5 and implemented 3 requirements, the use cases are consistent and clear. However, new use cases are missing test cases

Video Demo: Excellent 2/2

Excellent video demo

Manager’s Best Pick: 1/1

Creative and neat UI and tree View
Nice and organized work, worth promoting

Summary: 20/24 ------after capping------> 20/20

This is based on rubric of part 4. Feel free to contact me were there any concerns. haiming1[at]ualberta.ca