Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video files not resizing properly on opera browser #283

Open
aeonSolutions opened this issue Jun 10, 2024 · 7 comments
Open

Video files not resizing properly on opera browser #283

aeonSolutions opened this issue Jun 10, 2024 · 7 comments
Assignees

Comments

@aeonSolutions
Copy link

aeonSolutions commented Jun 10, 2024

What steps does it take to reproduce the issue?
after uploading a video file to a dataset when opening the dataset page, the video file in the dataset
on loading the webpage the video does not resize properly to match the iframe within the web page. As a consequence, it is impossible to view the video.

Anyone can evaluate this by looking at the file in Harvard's Dataverse at https://dataverse.harvard.edu/file.xhtml?fileId=6963014&version=1.0

When does this issue occur?
when I open a dataset with video files.
when I want to view the video on the webpage itself.

Which page(s) does it occurs on?
in the dataset web page

What happens?
The video file is not resized properly to match the iframe and webpage dimensions.

To whom does it occur (all users, curators, superusers)?
anyone with access.

What did you expect to happen?
I expect to view the video on the dataset web page without any effort.

Which version of Dataverse are you using?
web version hosted at Harvard University.

Screenshots:
image

@pdurbin
Copy link
Member

pdurbin commented Jun 10, 2024

@aeonSolutions hi! I believe @gwendoux just fix this with this PR:

The next steps would be to release a new version of the previewers and install them on various installations, such as Harvard Dataverse.

@cmbz
Copy link
Collaborator

cmbz commented Jun 24, 2024

@qqmyers Who would need to release a new version of the previewers, as per @pdurbin 's question: #283

@cmbz cmbz transferred this issue from IQSS/dataverse Jun 24, 2024
@cmbz
Copy link
Collaborator

cmbz commented Jun 24, 2024

2024/06/24
Transferred the issue, waiting on the next release to test and close.

@qqmyers
Copy link
Member

qqmyers commented Jun 24, 2024

#61 has been merged and that update is available in the betatest folder and the URL https://gdcc.github.io/dataverse-previewers/previewers/betatest/VideoPreview.html now. (The updated previewer can also be installed locally or one could add the 1 line in the css file from #61 into an existing local install.) So a previewer release is not a technical blocker.

W.r.t. policy/process - there's nothing formal. Releases have usually been done by me when there have been enough updates that it seems worth advertising and having community members run through an update. In general, anyone could call for and add a PR to make a release, but I would say that so far there haven't been as many/as significant changes as we usually waited for. E.g. v.1.4 included 8 new previewers and the update to signed URLs. That was perhaps an overly long wait, but the community had access to all of this via the betatest folder prior to the official release.

@sbarbosadataverse
Copy link

@qqmyers Hey Jim, Are you planning on releasing this previewer? There is no labeling or project attached to this issue so it keeps coming up in our biweekly git review. Thanks

@qqmyers
Copy link
Member

qqmyers commented Jul 31, 2024

I'm not planning on a release any time soon. The previewer is usable now either from the betatest folder or by downloading and running the previewer locally.

@cmbz
Copy link
Collaborator

cmbz commented Aug 19, 2024

2024/08/19

  • Placed on hold. @sbarbosadataverse will monitor and we will revisit during the next Dataverse monthly meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: On Hold ⌛
Development

No branches or pull requests

5 participants