Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduces max video width to match iframe width #61

Merged
merged 1 commit into from
May 23, 2024
Merged

reduces max video width to match iframe width #61

merged 1 commit into from
May 23, 2024

Conversation

gwendoux
Copy link

when the video is too wide, it is not displayed in its entirety. By adjusting the maximum width of the preview, you can display the video more gracefully.

3467bab7c8ce7e9c241f2b4ea6e9aeeeb971ead23b3dea80c41bc7b4de6a2dd3

Copy link

@BenediktMeierUIT BenediktMeierUIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should also be entered in the file?

@gwendoux
Copy link
Author

Oh thanks, I did miss that one

@qqmyers
Copy link
Member

qqmyers commented May 22, 2024

By policy, we don't change prior versions - a normal restriction and more important since they may be used live from github.io by various installations. If this can be changed to be a betatest-only PR, we can merge it. (And consider a v1.5 release when this and some other PRs are finished).

@gwendoux
Copy link
Author

gwendoux commented May 22, 2024

it's understandable, I make the modification only on betatest
It seemed odd to me afterwards that there was so much redundancy for a single modification.

@gwendoux
Copy link
Author

@qqmyers I cleaned up the pull-request. Thanks

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants