Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from builtinuser table to authenticatedusertable for certain pages #1450

Closed
eaquigley opened this issue Feb 13, 2015 · 10 comments
Closed

Comments

@eaquigley
Copy link
Contributor

Currently the builtinuser table is being used to populate information on:

  1. Account Information page
  2. Create Dataverse/General Information Dataverse page
  3. Create/Edit Dataset Metadata

however, since we have moved some components of the builtinuser table to the authenticateduser table, we need to change it so these pages are calling from the authenticateduser table.

@scolapasta
Copy link
Contributor

#965 #945

@scolapasta
Copy link
Contributor

I think this is all set for 2 and 3. 1 is a bit messy, so I suggest deferring display of account info for none built in (since they also cannot edit) to 4.0.x.

@scolapasta scolapasta assigned eaquigley and unassigned scolapasta Feb 17, 2015
@eaquigley
Copy link
Contributor Author

Passing to QA to confirm 2 & 3. Please send back to me after that so I can decide what to do with 1. thanks! @kcondon

@kcondon
Copy link
Contributor

kcondon commented Feb 19, 2015

OK, 2,3 look good both with builtin and shib user. Passing back to Liz as requested.

@kcondon kcondon assigned eaquigley and unassigned kcondon Feb 19, 2015
@scolapasta scolapasta modified the milestones: Beta 14 - Dataverse 4.0, In Review - Dataverse 4.0 Feb 20, 2015
@eaquigley
Copy link
Contributor Author

We will the text from the Account Information edit dropdown appear in this tab instead of there.

@eaquigley
Copy link
Contributor Author

@mheppler Currently when a user logs in via Shibb and goes to their account page, they see this:
shibbaccount1

When they click on the Account Info dropdown, they see this:
shibbaccount2
(bonus, this text is mentioned in the Bundle ticket #1442 )

We need to move the text from that dropdown (so only API Token is left) and have it displayed in the Account Information tab. However, that texts doesn't make sense so it should say: "You are logged in through your institution so Dataverse is not able to display your account information. If you need to update any of this information, please contact your institution."

mheppler added a commit that referenced this issue Feb 24, 2015
… suggested, updated text. Moved it from Account Information dropdown to the Account Information tab on the Account page. [ref #1450, #1442]
@mheppler
Copy link
Contributor

Added back user.toEditDetail message to bundle, and revised it to the suggested, updated text. Moved it from Account Information dropdown to the Account Information tab on the Account page.

@pdurbin
Copy link
Member

pdurbin commented Mar 7, 2015

I suggest deferring display of account info for [non] built in (since they also cannot edit) to 4.0.x.

Is there a ticket for this? Shib users still see something like this:

account_-root_dataverse-_2015-03-05_16 35 58

@scolapasta
Copy link
Contributor

This is what was decided for 4.0, rather than remove the tab (hence @equigley adding her comments).

One quick note: it's not that we can't display your account info (because we will in a future version, or at least the parts we get from shib, etc), so I think that line is a little misleading. Can we remove it?

So: "You are logged in through your institution. If you need to update any of this information, please contact your institution."

@scolapasta scolapasta assigned eaquigley and unassigned kcondon Mar 7, 2015
@scolapasta scolapasta assigned kcondon and unassigned eaquigley Mar 10, 2015
eaquigley added a commit that referenced this issue Mar 10, 2015
Updated logged in Shibboleth info from #1450
@kcondon
Copy link
Contributor

kcondon commented Mar 20, 2015

OK, message is there. @eaquigley wording is not exactly as you specified but seems close enough. Closing.

@kcondon kcondon closed this as completed Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants