Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot download guestbook in Chrome if Dataverse has a "," in the name #4512

Closed
scolapasta opened this issue Mar 15, 2018 · 3 comments
Closed

Comments

@scolapasta
Copy link
Contributor

Discovered by CCAFS:
https://dataverse.harvard.edu/dataverse/CCAFSbaseline

If a Dataverse has a "," in the name, the user gets an error when downloading guestbook responses via Chrome.

ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION

This looks to be easily solved by adding quotes around the filename when setting the Content-Disposition header (see https://stackoverflow.com/questions/13578428/duplicate-headers-received-from-server)

At the same time we should consider:

  • by adding these quotes, we likely don't need to replace spaces with "_".
  • would it be better to use the guestbook name as the name instead of dataverse name and id (@jggautier ?)
@jggautier
Copy link
Contributor

jggautier commented Mar 16, 2018

would it be better to use the guestbook name as the name instead of dataverse name and id (@jggautier ?)

Or the name of the guest book plus the name of its dataverse? I'm not sure yet how many dataverse admins collect and need to sort many guestbook CSVs from the same dataverse. And if they'd find the extra info in the file names helpful.

@mheppler
Copy link
Contributor

Retracted closing issue as a duplicate of #4671.

@mheppler
Copy link
Contributor

mheppler commented Mar 6, 2019

Apparently I already tried to close this issue as a duplicate. So this time, lets leave this one open, and close Guestbook: Cannot download a particular guestbook using Chrome, throws duplicate header error #3581 as the duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants