Dataverse Guestbook: Custom question output has inconsistent order

[umuchlish]

Hi @pdurbin, as per discussion during dinner at that old town Bandung to open a ticket.

I have found my Guestbook csv data has inconsistent order, especially for custom question.

While visiting the code, not related above case or perhaps related a bit: https://github.com/IQSS/dataverse/blob/v4.8.6/src/main/java/edu/harvard/iq/dataverse/GuestbookResponseServiceBean.java#L147

Please add quote (“) to each field and data to avoid the content being misplaced rather than do intervention to the data by replace ",".

out.write(""Guestbook", "Dataset", "Date", "Type", "File Name", "File Id", "User Name", "Email", "Institution", "Position", "Custom Questions"\n".getBytes());

perhaps:
sb.append(""");
sb.append(((String)result[1]));
sb.append(""");
sb.append(SEPARATOR);

or better....

[pdurbin]

@umuchlish nice meeting you last week and thanks for reporting this bug. We discussed it during our backlog grooming meeting just now and we agree that a fix should be fairly straightforward. Over at https://waffle.io/IQSS/dataverse?search=4671 you can see that we estimated it as a "1" and moved it from the Inbox to the Backlog.

[mheppler]

@kcondon had mentioned this new issue was already reported. Found it.

Guestbook: Guestbook csv download has issues if contents also includes commas, title, text q. #3449

Here is another duplicate.

Cannot download guestbook in Chrome if Dataverse has a "," in the name #4512

After discussing with @scolapasta reopening #4512, who said, "still a 1, but a different 1, I vote for keeping it open".

[mheppler]

@kcondon commented on Nov 2, 2016 in issue Guestbook: Guestbook csv download has issues if contents also includes commas, title, text q. #3449

Found by a user, see RT 243224, if a dataset's title contains a comma, loading the guestbook download csv into a spreadsheet requires manually removing the comma before it is properly imported. This would also happen if a question had commas or an answer had commas.

One solution might be to scrub commas from content when writing this doc.

Closed that issue as a duplicate.

[pdurbin]

As I mentioned in standup, I'm having trouble reproducing this issue. @sekmiller said he'd help me try (thanks!) but if @umuchlish or @kaitlinnewson or others have specific scenarios they'd like to have tested, please comment here. Thanks!

[pdurbin]

Ok, I think I was obsessed with the commas but @sekmiller just pointed out that both the interface and the CSV but custom questions in an indeterminate order. For example, in the CSV I see a mix of "How's the weather?" and "Any trips planned?" in the same column:

As @sekmiller pointed out, this mixture is also reflected in the GUI so we'll need to make sure it's fixed in both places:

[pdurbin]

I just made pull request #4700 and would love some code review so I moved this issue to that column in Waffle.

While I was in there I was struck by how downloading a guestbook is an operation you can only do from the GUI rather than the API so I added it to the list at #3440. If any users of Dataverse want this, please create a new issue for just downloading a guestbook via API because #3440 is a long list and we try to work in small chunks. Thanks.