Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve order of custom questions #4671 #4700

Merged
merged 2 commits into from
May 23, 2018
Merged

preserve order of custom questions #4671 #4700

merged 2 commits into from
May 23, 2018

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented May 21, 2018 •
edited
Loading

@pdurbin pdurbin mentioned this pull request May 21, 2018
Closed
@coveralls
Copy link

coveralls commented May 21, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.0007%) to 13.178% when pulling 9ab3a4d on 4671-guestbook-question-order into 745e616 on develop.

@pdurbin
go ahead address the FIXME to add a space #4671
9ab3a4d 
The lack of the space doesn't seem to affect the query but it's hard on
the eyes. Best to fix it now.
@kcondon kcondon merged commit 94a0ed5 into develop May 23, 2018
@kcondon kcondon deleted the 4671-guestbook-question-order branch May 23, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.9 - Persistent Identifiers for Files
Development

Successfully merging this pull request may close these issues.
3 participants
@pdurbin @coveralls @kcondon