Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and move from Solr 8.X to Solr 9.X #9260

Closed
4 tasks
carlsonp opened this issue Jan 4, 2023 · 11 comments · Fixed by #9787
Closed
4 tasks

Test and move from Solr 8.X to Solr 9.X #9260

carlsonp opened this issue Jan 4, 2023 · 11 comments · Fixed by #9787
Labels
D: Payara 6 Upgrade Issues and PRs about the move to Jakarta EE 10 + Payara 6 Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)
Milestone

Comments

@carlsonp
Copy link
Contributor

carlsonp commented Jan 4, 2023

Overview of the Feature Request

Solr 8.X, specifically, 8.11.2 according to this page: "is the last release in the 8.x series." This means it likely won't be receiving any more updates, features, or patches. This also may have implications from a security perspective. The Dataverse Solr schema and major changes should be reviewed and tested.

  • Evaluate and update Solr schema if needed
  • Smoke-test with Solr 9.X
  • Update documentation
  • Document migration steps?

What kind of user is the feature intended for?

Sysadmin and developers

What inspired the request?

What existing behavior do you want changed?

Any brand new behavior do you want to add to Dataverse?

Any related open or closed issues to this feature request?

@pdurbin
Copy link
Member

pdurbin commented Jan 17, 2023

@carlsonp hi! Thanks for pointing this out. As I said, Solr moves quickly! Again if you're interested in making a pull request, you might be able to follow the pattern of Solr upgrades in previous PRs:

@pdurbin
Copy link
Member

pdurbin commented Feb 7, 2023

Not sizing this for now. Hoping we can help @carlsonp make a pull request. 😄 Please let us know!

Please note that this issue and PR are related:

This might be somewhat easy to test by bumping the Solr version in dataverse-ansible (@donsizemore would know).

@carlsonp
Copy link
Contributor Author

carlsonp commented Feb 23, 2023

Migration away from Solr 8.X would help us in our intended deployment of Dataverse to Azure commercial. We're getting a lot of pushback on vulnerabilities both false-positives in the eyes of the Apache foundation as well as other vulnerabilities as CVEs. From scanning tools, they're picking up these CVEs and our Cybersecurity team wants them to be patched. We aren't interested in forking or patching upstream Solr so it seems Solr 9.X is a better longer-term solution. When I push and scan Solr 9.X there are less CVEs listed. This could be a major hold-up or full blocker in our ability to run Dataverse.

@pdurbin
Copy link
Member

pdurbin commented Feb 28, 2023

@carlsonp makes sense. Would you be able to email a list of Solr CVEs your tool is picking for Solr 8.11.1 (the version we use currently) to security@dataverse.org?

@mreekie
Copy link

mreekie commented Feb 28, 2023

Grooming:

  • Including as part of Payara 6 upgrade deliverable

@mreekie mreekie added the D: Payara 6 Upgrade Issues and PRs about the move to Jakarta EE 10 + Payara 6 label Feb 28, 2023
@donsizemore
Copy link
Contributor

donsizemore commented Mar 6, 2023

@pdurbin I just heard from our security group about my brand-new private Dataverse instances. Per Solr's security page https://solr.apache.org/security.html we're not realistically vulnerable to the CVEs in question, but I opened https://github.com/IQSS/dataverse-security/issues/79 in response to the newer CVE.

@carlsonp
Copy link
Contributor Author

carlsonp commented Mar 6, 2023

@carlsonp makes sense. Would you be able to email a list of Solr CVEs your tool is picking for Solr 8.11.1 (the version we use currently) to security@dataverse.org?

This is complete.

@scolapasta scolapasta added this to the 6.0 milestone May 15, 2023
@cmbz
Copy link

cmbz commented May 15, 2023

  • Prioritizing Payara 6 release
  • Sizing needed

@cmbz
Copy link

cmbz commented May 17, 2023

Sized as 33
Note: Has some requirements that might impact upgrade

@cmbz cmbz added the Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) label May 17, 2023
@pdurbin pdurbin self-assigned this Aug 14, 2023
pdurbin added a commit that referenced this issue Aug 14, 2023
Update all Solr references from 8.11.1 to 9.3.0 and
make sure you can spin up containers.

schema.xml was copied from
solr-9.3.0/server/solr/configsets/_default/conf/managed-schema.xml

(Note managed-schema.xml as there is no schema.xml upstream.)

solrconfig.xml was copied from
solr-9.3.0/server/solr/configsets/_default/conf/solrconfig.xml

API tests will fail, of course, because we have not yet added
our Dataverse-specific config. We'll be moving it from these
files and then deleting them:

conf/solr/8.11.1/schema.xml
conf/solr/8.11.1/solrconfig.xml
pdurbin added a commit that referenced this issue Aug 15, 2023
In an earlier commit, a vanilla 9.3.0/schema.xml
was added.

Now we add the Dataverse-specific fields we need.

We also delete the old 8.11.1/schema.xml file.
pdurbin added a commit that referenced this issue Aug 15, 2023
Note that even with these tweaks there are still errors.

The current error is "possible analysis error".
pdurbin added a commit that referenced this issue Aug 16, 2023
@pdurbin pdurbin removed their assignment Aug 16, 2023
@pdurbin
Copy link
Member

pdurbin commented Aug 16, 2023

@carlsonp I finally made a PR!

Please come back! ❤️ It's even containerized!!!11! 😄 🚀 🎉

pdurbin added a commit that referenced this issue Aug 18, 2023
Conflicts:
downloads/download.sh
scripts/vagrant/setup.sh
@carlsonp
Copy link
Contributor Author

Awesome! :D

pdurbin added a commit that referenced this issue Aug 22, 2023
pdurbin added a commit that referenced this issue Aug 23, 2023
pdurbin added a commit that referenced this issue Aug 24, 2023
pdurbin added a commit that referenced this issue Aug 24, 2023
We don't need the scripting module anymore.
pdurbin added a commit that referenced this issue Aug 24, 2023
pdurbin added a commit that referenced this issue Aug 28, 2023
pdurbin added a commit that referenced this issue Aug 28, 2023
pdurbin added a commit that referenced this issue Aug 28, 2023
pdurbin added a commit that referenced this issue Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: Payara 6 Upgrade Issues and PRs about the move to Jakarta EE 10 + Payara 6 Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

6 participants