Resolve conflicting version of MIME4J #10301
Conversation
- Apache Abdera Parser, Apache Tika and RESTeasy (Testing) use MIME4J - Tika and RESTeasy use newer APIs only present since v0.8+ - Abdera is an abandoned project, uses v0.7.2 and is hopefully compatible with newer releases - v0.8.4 given by Apache Tika relies on vulnerable Apache Commons IO 2.6, we want 2.11 per dependency management. Upgrading to v0.8.7 as earliest version with 2.11 dependency
This comment has been minimized.
This comment has been minimized.
|
@poikilotherm tika has a v2.9.1 (we're at 2.4.1) which I think includes the v0.8.7 version you want. Should we upgrade tika in addition/instead? 2.9.1 looks like it works as well or better than the earlier version at QDR. Re: testing - we don't have a suite of files to test all of full-text indexing so the basic test would be to configure full-text indexing (":SolrFullTextIndexing":"true"), reindex a dataset with test file(s) of various types, and see if they appear in search results for a term in the text (and don't appear in search when full-text is off). |
poikilotherm
added
Feature: Indexing
Size: 3
|
I agree - we should upgrade Tika. Let me check if I can provide a Testcontainers based integration test, would be interesting to have this use case properly covered by a nice integration test. |
This comment has been minimized.
This comment has been minimized.
qqmyers
added
GDCC: DANS
qqmyers
added
the
Consider For Next Release
|
@poikilotherm can you please resolve merge conflicts? ❤️ |
Conflicts: pom.xml
There was a problem hiding this comment.
@poikilotherm nevermind. I resolved them. I didn't run the code myself but I'm approving this.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
Spoke to Jim about testing this. Essentially, I performed a smoke test with SolrFullTextIndexing set to true. No issues found during testing. Merging PR. |
What this PR does / why we need it:
Which issue(s) this PR closes:
Closes #9077
Special notes for your reviewer:
None
Suggestions on how to test this:
Let Jenkins run the SWORD2 tests. Maybe @qqmyers can tell us how to run tests for full text indexing?
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope
Is there a release notes update needed for this change?:
Nope
Additional documentation:
None