-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for Stata 14 and 15 #2301 #4708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"TestIngestIT" matches "Test" so it was be executed by Maven and Travis.
This was to confirm functionality before parsing strls for stata 14.
The old Stata 13 parser benefits from this hack as well so I added it.
Report added to spreadsheet here: https://docs.google.com/spreadsheets/d/1HcBMgky-ZgtnP2SGmoBFaL2vFL-Eepx0rX0tiXvrsmo/edit?usp=sharing
…so lets tests work better)
…re no longer relevant.
…relied upon, added tests.
…vector indicating a missing value in Stata. Removed the TODO next to the comment. Should be ready for QA.
@kuriwaki yes, that's right. Would you be able to create an issue to fix the docs/website? |
pdurbin
added a commit
that referenced
this pull request
Dec 11, 2019
Support was added in Dataverse 4.9.2 in #4708 This is just a documentation update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to #2301 Ingest: Update Stata 13 ("New Stata") ingest plugin; add support for v.14 and v.15; fix bugs in handling of v.13 format
We are also putting this issue through QA: #2218 File Ingest: Large dta file partially completes ingest before failing, leaves file in incorrect state.