-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IQSS/5043 streaming and new exporters #5047
IQSS/5043 streaming and new exporters #5047
Conversation
QDR-953_streaming_exports Conflicts: src/main/java/edu/harvard/iq/dataverse/DataCitation.java
@@ -209,17 +205,17 @@ public void exportFormat(Dataset dataset, String formatName) throws ExportExcept | |||
if (releasedVersion == null) { | |||
throw new IllegalStateException("No Released Version"); | |||
} | |||
JsonPrinter jsonPrinter = new JsonPrinter(settingsService); | |||
final JsonObjectBuilder datasetAsJsonBuilder = jsonPrinter.jsonAsDatasetDto(releasedVersion); | |||
final JsonObjectBuilder datasetAsJsonBuilder = JsonPrinter.jsonAsDatasetDto(releasedVersion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if no longer passing "settingsService" into the JsonPrinter constructor has led to #5185 about ":ExcludeEmailFromExport" no longer working.
@kcondon - Since this PR updates the citation.tsv file, I think the release notes should tell people to run the curl api command to reinstall it. Is there someplace you capture that? |
@qqmyers Yes, I've documented it in my release deployment doc which I use to both deploy in prod and to write upgrade instructions: Thanks for noticing! |
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist