Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iqss/4706 dpn submission of archival copies #5049

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Sep 11, 2018

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@qqmyers
Copy link
Member Author

qqmyers commented Sep 11, 2018

This PR includes PRs #5035, #5047, and #5048. Only the last 2 commits are unique.

@coveralls
Copy link

coveralls commented Sep 11, 2018

Coverage Status

Coverage decreased (-0.2%) to 17.36% when pulling 8d09fbf on QualitativeDataRepository:IQSS/4706-DPN_Submission_of_archival_copies into c0f1655 on IQSS:develop.

@qqmyers
Copy link
Member Author

qqmyers commented Sep 26, 2018

merging changes from other branches and fixed a bug in creating the bag info file when the contact and description fields have been given different URIs.

Conflicts:
	src/main/java/edu/harvard/iq/dataverse/api/Admin.java
Conflicts:
	pom.xml
	src/main/java/edu/harvard/iq/dataverse/api/Admin.java
	src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
Conflicts:
	src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractPublishDatasetCommand.java
	src/main/java/edu/harvard/iq/dataverse/engine/command/impl/FinalizeDatasetPublicationCommand.java
	src/main/java/edu/harvard/iq/dataverse/engine/command/impl/PublishDatasetCommand.java
	src/main/java/edu/harvard/iq/dataverse/workflow/PendingWorkflowInvocation.java
	src/main/java/edu/harvard/iq/dataverse/workflow/WorkflowContext.java
	src/main/java/edu/harvard/iq/dataverse/workflow/WorkflowServiceBean.java
@pdurbin
Copy link
Member

pdurbin commented Jan 9, 2019

My first thought is that someone could try the fancy new ec2-create-instance.sh script on @qqmyers 's branch. The syntax would be

./ec2-create-instance.sh -b IQSS/4706-DPN_Submission_of_archival_copies -r https://github.com/QualitativeDataRepository/dataverse.git

See also http://guides.dataverse.org/en/4.10.1/developers/deployment.html

@kcondon
Copy link
Contributor

kcondon commented Jan 10, 2019

I'm putting this back into dev for now.

@qqmyers
Copy link
Member Author

qqmyers commented Jan 11, 2019

@kcondon - while I still don't understand why several of us can build and you can't, I did find the dependency for the log4j-over-slf4j.jar in the duracloud libraries and I've updated the pom to exclude it (latest commit). I've verified that the excludes remove that jar and don't affect submission to Duracloud. So - if this works for you, I think we're good (despite the mystery if why it worked, it seems clear that both jars in the error message should not be in there.)

(Also FWIW: I noticed that the version 1.7.7 of the SLF4J jars was hardcoded in the pom.xml as of Dataverse 4.3 and they're up to v1.7.25 now...)

qqmyers and others added 22 commits January 14, 2019 12:35
One of the main reasons for this is that we don't want to hard-code
guides.dataverse.org because it's configurable using the :GuidesBaseUrl
database setting.
I also removed the indenting for consistency with other pages but we
probably have a mix of styles.
move details about DuraCloud/Chronopolis setup IQSS#4706
Fix command line so accept file type.
Remove unneeded character from command line
@kcondon kcondon merged commit 14fa723 into IQSS:develop Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants