Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain how developers can run the API test suite on EC2 #6344

Merged
merged 1 commit into from
Nov 7, 2019
Merged

explain how developers can run the API test suite on EC2 #6344

merged 1 commit into from
Nov 7, 2019

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Nov 5, 2019

Screen Shot 2019-11-05 at 2 53 48 PM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.461% when pulling 520240f on dev-run-api-test-suite into b46243d on develop.

@djbrooke
Copy link
Contributor

djbrooke commented Nov 5, 2019

I assigned myself and @TaniaSchlatter because we are both interested in spinning up branches to play with code changes that are working their way through the development process. I thought this was that. This is not that, so I'm removing us from the issue. We'll schedule some time in the future to go through the existing docs.

@pdurbin
Copy link
Member Author

pdurbin commented Nov 5, 2019

@djbrooke for this to be that you would skip this step:

  • Edit ec2config.yaml to change test_suite to true.

@djbrooke
Copy link
Contributor

djbrooke commented Nov 5, 2019

@pdurbin this isn't what I'm looking to make easier for me and others. What I'm looking to make easier is everything in the "deployment" section. This PR is fine to move along, but it's not what I'm looking for.

@pdurbin pdurbin mentioned this pull request Nov 5, 2019
Closed
mheppler
mheppler approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@mheppler mheppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@mheppler mheppler removed their assignment Nov 7, 2019
@kcondon kcondon self-assigned this Nov 7, 2019
@kcondon kcondon merged commit 0c85fa9 into develop Nov 7, 2019
@kcondon kcondon deleted the dev-run-api-test-suite branch November 7, 2019 20:40
@djbrooke djbrooke added this to the 4.18 milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheppler mheppler mheppler approved these changes

@bsilverstein95 bsilverstein95 Awaiting requested review from bsilverstein95

Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.18
Development

Successfully merging this pull request may close these issues.
6 participants
@pdurbin @coveralls @djbrooke @mheppler @kcondon @TaniaSchlatter