Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5292 mvn container #7245

Closed
wants to merge 38 commits into from
Closed

5292 mvn container #7245

wants to merge 38 commits into from

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Aug 31, 2020 •
edited
Loading

What this PR does / why we need it:
This pull request will add official images to the upstream repository.

  1. There is no way around this, as any modern container building tools reusing the Maven environment have to reside in the projects pom.xml.
  2. Adding the necessary bits here allows to reuse pom.xml as the source of truth by reusing its dependency versions written down in properties.
  3. Providing this here allows for using any version/commit of Dataverse in a container right away. Building is fast, reusing layers and local Maven cache.
  4. Images from this will be reusable with Testcontainers and Docker-Compose.

Which issue(s) this PR closes:
Closes #5292

Special notes for your reviewer:

  • Build with mvn -P container package docker:build
  • Building the Solr image is still TBD.
  • Fun fact: is Dataverse 5 in general much faster to deploy or is it the new layer arch providing deployment times of about 45 secs?

Suggestions on how to test this:
Nothing yet.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.

Is there a release notes update needed for this change?:
Later on.

Additional documentation:
We should debate if @IQSS is willing to provide testing and QA for this type of stuff. Adding a label for good distinction.

@poikilotherm poikilotherm added the Component: Containers Anything related to cloudy Dataverse, shipped in containers. label Aug 31, 2020
@poikilotherm poikilotherm self-assigned this Aug 31, 2020
@coveralls
Copy link

coveralls commented Aug 31, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 19.324% when pulling d78e463 on poikilotherm:5292-mvn-container into b61b572 on IQSS:develop.

@poikilotherm poikilotherm mentioned this pull request Feb 8, 2021
Closed
@poikilotherm poikilotherm mentioned this pull request Mar 18, 2021
Closed
@poikilotherm poikilotherm mentioned this pull request Mar 18, 2021
Merged
pdurbin and others added 21 commits March 22, 2021 14:06
@pdurbin
include previous note about upgrading IQSS#7700
4e94a80
@poikilotherm
Merge branch 'develop' into 7700-payara-5.2021.1
b64e289
@poikilotherm
chore(appserver): upgrade to Payara 5.2021.2 IQSS#7700
804086e
@poikilotherm
Merge branch 'develop' into 7700-payara-5.2021.1
541a645
@poikilotherm
chore(appserver): update to Payara 5.2021.3 IQSS#7700
2fb09ea
@poikilotherm
Merge branch 'develop' into 7700-payara-5.2021.1
78b1d24
@poikilotherm
chore: update release note on Payara upgrade to Dataverse 5.6
8b51789
@poikilotherm
chore(appserver): update to Payara 5.2021.4 IQSS#7700
bf72ff9
@poikilotherm
Proof of concept creating a (non-working) container image for Dataver…
724c335 
…se based on Payara
@poikilotherm
Add supplemental data and scripts plus JRebel lib to application cont…
0ee2251 
…ainer image.
@poikilotherm
Add init scripts to the Dataverse application image.
cde55bc
@poikilotherm
Add usage scripts for config, bootstrap and metadata blocks to Datave…
17fdd36 
…rse application container image.
@poikilotherm
Make the Docker Maven Plugin Profile usable with Skaffold.
b4ebe04
@poikilotherm
Update docker-maven-plugin to 0.34.1. IQSS#5292
8ed0d63
@poikilotherm
dataverse-k8s: remove postgres client lib handling as IQSS#6819 has b…
e19852c 
…een resolved.
@poikilotherm
dataverse-k8s: fix typo in startup script for disable-phone-home
9775971
@poikilotherm
dataverse-k8s: remove reference_data.sql loading from bootstrap, as I…
5ae67f3 
…QSS#7256 introduced a migration for this.
@poikilotherm
dataverse-k8s: small doc correction in Dockerfile
4cad6d5
@poikilotherm
Remove POSTGRES vars from default.config, no longer necessary. IQSS#7418
d90a3bf
@poikilotherm
Create symlinks for jHove in Dockerfile.
5698a97
@poikilotherm
Container init script: remove jHove symlink (see Dockerfile), remove …
f73b3b3 
…JMS and JDBC handling due to IQSS#7418 and IQSS#7423
@poikilotherm
Move to JDK 11 as Dataverse 5.4+ is updated to recent Java LTS.
4cd2eca
@poikilotherm
feature(container): Refactor Dockerfile basing on openjdk:11-jre
6b96b71 
Instead of using the upstream Payara image we build on the OpenJDK
image which is also used by Solr. That way we reduce image pulls.
We also optimize the domain1 configuration to be more production ready.

Relates to IQSS#5292
@poikilotherm
feature(container): Make domain1 more production ready
c75b507 
1. Moving some specifics from the startup script to the build time config,
   saving time during startup.
2. Enlarging thread pools, setting better options for memory management
   and many other optimizations for using in production.

See also gdcc/dataverse-kubernetes#218
Relates to IQSS#5292
@poikilotherm
feature(container): adding more packages for analysis inside containe…
eccbdbf 
…r plus jattach
@poikilotherm
feature(container): make pom.xml contain a variable for the Solr version
01c0f26
@poikilotherm
feature(solr): add a Solr container with our prebaked schema and solr…
d5d90ad 
…config.
@poikilotherm
fix(container): fix missing version info in deployment with temporary…
63bc42a 
… workaround.
@poikilotherm
refactor(container): make dv and solr container different profiles, s…
3dd85c6 
…horten profile names to ct & solr-ct
@poikilotherm
refactor(pom): upgrade Maven plugins, stop using special JDK9+ profile
9e3f992
@poikilotherm
refactor(container): reunite the docker images to enable usage with r…
6d6b9d1 
…un & start targets, etc. IQSS#5292
@poikilotherm
feature(container): add simple run configuration to start Dataverse, …
e94024c 
…Solr and Postgres in single Maven call. IQSS#5292
@poikilotherm
Copy link
Contributor Author

I'll close this for now.
At some time in the future we might decide upon merging an evolved version of https://github.com/gdcc/dataverse/tree/develop+ct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@poikilotherm poikilotherm

Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Epic: small footprint container usable for development, testing and production purposes
3 participants
@poikilotherm @coveralls @pdurbin