Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Maven use for builds and more #186

Closed
poikilotherm opened this issue Apr 20, 2020 · 3 comments · May be fixed by #222
Closed

Enable Maven use for builds and more #186

poikilotherm opened this issue Apr 20, 2020 · 3 comments · May be fixed by #222
Labels
documentation Relating to docs enhancement enhancement New feature or request
Milestone

Comments

@poikilotherm
Copy link
Member

poikilotherm commented Apr 20, 2020

Inspired by https://github.com/payara/Payara/tree/master/appserver/extras, it would be nice to look into using Maven for images and maybe more.

We could try to compile Dataverse as a submodule. When that submodule would allow for packaging an installation bundle (instead of using automake), it would greatly ease image building and reduce complexity.

It might also be used to replace Skaffold with the right plugins to deploy images to a cluster. (Or integrated with a custom skaffold build call to Maven). IIRC there are Maven plugins for docker-compose, too.

@poikilotherm poikilotherm added the crazy ideas Let's get crazy... label Apr 20, 2020
@poikilotherm
Copy link
Member Author

Using JIB is so easy...

        <profile>
            <id>jib</id>
            <properties>
                <skipUnitTests>true</skipUnitTests>
            </properties>
            <build>
                <plugins>
                    <plugin>
                        <groupId>com.google.cloud.tools</groupId>
                        <artifactId>jib-maven-plugin</artifactId>
                        <version>2.4.0</version>
                        <configuration>
                            <from>
                                <image>docker.io/payara/server-full:${payara.version}</image>
                            </from>
                            <to>
                                <image>docker.io/gdcc/dataverse-k8s</image>
                            </to>
                            <container>
                                <appRoot>/opt/payara/deployments/dataverse</appRoot>
                            </container>
                        </configuration>
                    </plugin>
                </plugins>
            </build>
        </profile>

@poikilotherm
Copy link
Member Author

See https://github.com/poikilotherm/dataverse/tree/5292-mvn-container and IQSS/dataverse#7245 for progress on this, not using JIB but still having exploded WAR.

@poikilotherm poikilotherm added this to the v5.5 milestone Feb 8, 2021
@poikilotherm poikilotherm added documentation Relating to docs enhancement enhancement New feature or request and removed crazy ideas Let's get crazy... labels Feb 8, 2021
This was referenced Jun 18, 2021
@poikilotherm
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relating to docs enhancement enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant