-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5345 Make EJB timers nonpersistent #7416
Merged
kcondon
merged 5 commits into
IQSS:develop
from
poikilotherm:5345-nonpersistent-ejb-timers
Nov 24, 2020
Merged
5345 Make EJB timers nonpersistent #7416
kcondon
merged 5 commits into
IQSS:develop
from
poikilotherm:5345-nonpersistent-ejb-timers
Nov 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poikilotherm
added
Type: Feature
a feature request
Feature: Installer
Feature: Installation Guide
labels
Nov 17, 2020
5 tasks
This was referenced Nov 17, 2020
Merged
scolapasta
reviewed
Nov 20, 2020
scolapasta
reviewed
Nov 20, 2020
scolapasta
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohooo! 🌟 Thanks for merging @kcondon !!! 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As discussed in #5345, #7048, on IRC, Slack and Zoom plus this Google doc, we need to make the EJB timers non-persistent for enabling application-level database connection definitions.
Which issue(s) this PR closes:
Closes #5345
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
Yeah, a small one about removing the EJB timer database configuration setting on the app server. 🔋 included.
Additional documentation:
This is a quick and dirty solution, not very sophisticated for future enhancements. At some point in the future, we need to come back to the ideas of the Google Doc.