Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6819 jdbc driver war #7420

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Nov 17, 2020

What this PR does / why we need it:
Move the JDBC driver to the WAR, loading it from there instead of from the Glassfish libs.
No more manual installation, keeping all deps tight together via Maven POM. A huge benefit for testing and containers.

Which issue(s) this PR closes:

Closes #6819
Should be done after #7416

Special notes for your reviewer:
None?

Suggestions on how to test this:
Try usual database operations. If tested before #7416, check EJB timers.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.

Is there a release notes update needed for this change?:
Nope. Those will be necessary for #7418.

Additional documentation:
Nada.

@coveralls
Copy link

coveralls commented Nov 17, 2020

Coverage Status

Coverage remained the same at 19.48% when pulling af4f043 on poikilotherm:6819-jdbc-driver-war into df84e96 on IQSS:develop.

@poikilotherm poikilotherm removed this from the 5.3 milestone Nov 18, 2020
Conflicts:
pom.xml (payara version .2 vs .6)
Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (and as discussed)

@kcondon kcondon self-assigned this Nov 24, 2020
@kcondon kcondon closed this Nov 24, 2020
@kcondon kcondon reopened this Nov 24, 2020
@kcondon kcondon merged commit 25cb2eb into IQSS:develop Nov 24, 2020
@poikilotherm
Copy link
Contributor Author

🥳🥳🥳🥳

Thanks for merging @kcondon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Postgres JDBC driver in pom.xml
6 participants